redo ./run-test.sh based on MIRI_REPLACE_LIBRS_IF_NOT_TEST #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
nofake
branch
4 times, most recently
from
2b5ec9b to
c59a0cf
Compare
RalfJung
force-pushed
the
nofake
branch
3 times, most recently
from
97ed76b to
9aa46a5
Compare
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 6, 2024
…Simulacrum remove miri-test-libstd hacks that are no longer needed In rust-lang#123317 we developed a different approach to testing the standard library in Miri, and with rust-lang/miri-test-libstd#56 the out-of-tree miri-test-libstd has been switched to that approach. That makes these hacks here no longer necessary.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2024
Rollup merge of rust-lang#123541 - RalfJung:remove-old-hacks, r=Mark-Simulacrum remove miri-test-libstd hacks that are no longer needed In rust-lang#123317 we developed a different approach to testing the standard library in Miri, and with rust-lang/miri-test-libstd#56 the out-of-tree miri-test-libstd has been switched to that approach. That makes these hacks here no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rust-lang/rust#123317 having landed, there's a way to run the tests directly on the library source tree, without most of the hackery that was required before. (But in exchange we get new hackery in the form of MIRI_REPLACE_LIBRS_IF_NOT_TEST.)